Stream: git-wasmtime

Topic: wasmtime / PR #8305 fix: bindgen trappable_errors using u...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:40):

fibonacci1729 opened PR #8305 from fibonacci1729:fix-bindgen-bug to bytecodealliance:main:

This PR fixes a bug in the wasmtime::bindgen! macro when specifying trappable_errors and there is a versioned and unversioned representation of a package.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:43):

fibonacci1729 commented on PR #8305:

cc/ @alexcrichton

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:50):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:50):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:50):

alexcrichton created PR review comment:

I think this might be an accidental update?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 18:54):

fibonacci1729 updated PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:04):

fibonacci1729 updated PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:05):

fibonacci1729 has marked PR #8305 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:05):

fibonacci1729 requested fitzgen for a review on PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:05):

fibonacci1729 requested wasmtime-core-reviewers for a review on PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:06):

fibonacci1729 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:06):

fibonacci1729 created PR review comment:

Good catch! Updated to remove.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 19:14):

fibonacci1729 updated PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 20:15):

alexcrichton merged PR #8305.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 20:49):

alexcrichton commented on PR #8305:

I've opened backports for this at https://github.com/bytecodealliance/wasmtime/pull/8306 and https://github.com/bytecodealliance/wasmtime/pull/8307

Last updated: Dec 23 2024 at 12:05 UTC