Stream: git-wasmtime

Topic: wasmtime / PR #8299 cranelift/x64: Rely on zero-extended ...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:40):

jameysharp opened PR #8299 from jameysharp:x64-lower-consts to bytecodealliance:main:

Since #6850, we've been able to rely on iconst instructions having their immediate operands' high bits zeroed before lowering.

So a couple of places in x64/lower.rs can be expressed more simply now as a result.

Out of an abundance of caution, I added a debug-assertion when constants are looked up during lowering, to check that earlier phases really did ensure the high bits are zero.

I also got rid of an expect where a simple pattern-match will do.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:40):

jameysharp requested cfallin for a review on PR #8299.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:40):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8299.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:51):

jameysharp updated PR #8299.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:52):

jameysharp commented on PR #8299:

Turns out I can't use Option::inspect yet because it was stabilized in 1.76 and our MSRV is currently 1.75, whoops.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 19:56):

cfallin submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 20:55):

jameysharp merged PR #8299.

Last updated: Dec 23 2024 at 13:07 UTC