Stream: git-wasmtime

Topic: wasmtime / PR #8295 winch: Add support for address maps


view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera opened PR #8295 from saulecabrera:winch-addr-maps to bytecodealliance:main:

Closes https://github.com/bytecodealliance/wasmtime/issues/8095

This commit adds support for generating address maps for Winch.

Give that source code locations and machine code offsets are machine independent, one objective of this change is introduce minimal methods to the MacroAssesmbler and Asssembler implementations and tries to accomodate the bulk of the work in the ISA independent CodeGen module.

Address maps also enable using the wasmtime explore command with Winch via wasmtime explore -C compiler=winch <module.wasm>

<img width="1488" alt="Screenshot 2024-04-03 at 10 11 02 AM" src="https://github.com/bytecodealliance/wasmtime/assets/1423601/a5f3c6fd-ed7e-400e-823b-cefd1719d145">

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera requested abrown for a review on PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera requested fitzgen for a review on PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera requested wasmtime-core-reviewers for a review on PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:13):

saulecabrera requested elliottt for a review on PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 14:45):

github-actions[bot] commented on PR #8295:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 16:21):

saulecabrera edited PR #8295:

Closes https://github.com/bytecodealliance/wasmtime/issues/8095

This commit adds support for generating address maps for Winch.

Given that source code locations and machine code offsets are machine independent, one objective of this change is introduce minimal methods to the MacroAssesmbler and Asssembler implementations and tries to accomodate the bulk of the work in the ISA independent CodeGen module.

Address maps also enable using the wasmtime explore command with Winch via wasmtime explore -C compiler=winch <module.wasm>

<img width="1488" alt="Screenshot 2024-04-03 at 10 11 02 AM" src="https://github.com/bytecodealliance/wasmtime/assets/1423601/a5f3c6fd-ed7e-400e-823b-cefd1719d145">

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 21:18):

fitzgen submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 21:18):

fitzgen submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 03 2024 at 21:18):

fitzgen created PR review comment:

Update this method's docs to say that this returns the new machine ocode offset and source location? (IIUC)

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 11:55):

saulecabrera updated PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 11:56):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 11:56):

saulecabrera created PR review comment:

Done, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 11:56):

saulecabrera has enabled auto merge for PR #8295.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2024 at 12:38):

saulecabrera merged PR #8295.


Last updated: Dec 23 2024 at 12:05 UTC