Stream: git-wasmtime

Topic: wasmtime / PR #8279 Support dirs/env vars in `wasmtime se...

Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton opened PR #8279 from alexcrichton:serve-support-more-flags to bytecodealliance:main:

• More flags like --dir and --env are moved into RunCommon to be shared between wasmtime serve and wasmtime run, meaning that the serve command can now configure environment variables.

• A small test has been added as well as infrastructure for running tests with wasmtime serve itself. Previously there were no tests that executed wasmtime serve.

• The test_programs crate had a small refactoring to avoid double-generation of http bindings.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton requested fitzgen for a review on PR #8279.

Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8279.

Wasmtime GitHub notifications bot (Apr 02 2024 at 15:44):

fitzgen commented on PR #8279:

Did we resolve the discussion in https://github.com/bytecodealliance/wasmtime/issues/8086 about whether we actually want to do this kind of thing or not?

Wasmtime GitHub notifications bot (Apr 02 2024 at 16:04):

alexcrichton commented on PR #8279:

As https://github.com/bytecodealliance/wasmtime/issues/8086 is just about the default. This PR doesn't change the defaults, it just enables -Scli to be somewhat useful on wasmtime serve as previously you couldn't configure environment variables, preopens, etc.

Wasmtime GitHub notifications bot (Apr 02 2024 at 16:07):

fitzgen commented on PR #8279:

Ah okay, gotcha. Taking a look now.

Wasmtime GitHub notifications bot (Apr 02 2024 at 16:11):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Apr 02 2024 at 16:56):

fitzgen merged PR #8279.

Last updated: Nov 22 2024 at 16:03 UTC