Stream: git-wasmtime

Topic: wasmtime / PR #8279 Support dirs/env vars in `wasmtime se...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton opened PR #8279 from alexcrichton:serve-support-more-flags to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton requested fitzgen for a review on PR #8279.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8279.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2024 at 15:44):

fitzgen commented on PR #8279:

Did we resolve the discussion in https://github.com/bytecodealliance/wasmtime/issues/8086 about whether we actually want to do this kind of thing or not?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2024 at 16:04):

alexcrichton commented on PR #8279:

As https://github.com/bytecodealliance/wasmtime/issues/8086 is just about the default. This PR doesn't change the defaults, it just enables -Scli to be somewhat useful on wasmtime serve as previously you couldn't configure environment variables, preopens, etc.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2024 at 16:07):

fitzgen commented on PR #8279:

Ah okay, gotcha. Taking a look now.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2024 at 16:11):

fitzgen submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2024 at 16:56):

fitzgen merged PR #8279.


Last updated: Dec 23 2024 at 12:05 UTC