Stream: git-wasmtime

Topic: wasmtime / PR #8272 Fix errors becoming traps in wasi-http

Wasmtime GitHub notifications bot (Mar 31 2024 at 20:39):

alexcrichton opened PR #8272 from alexcrichton:no-trap-on-error to bytecodealliance:main:

This commit fixes an issue with errors in the wasmtime-wasi-http crate by using the trappable_error_type bindgen configuration option in the same manner as other WASI interfaces in the wasmtime-wasi crate. Unfortunately due to coherence the TrappableError<T> type itself could not be used but it was small enough it wasn't much effort to duplicate.

Closes #8269

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 31 2024 at 20:39):

alexcrichton requested fitzgen for a review on PR #8272.

Wasmtime GitHub notifications bot (Mar 31 2024 at 20:39):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8272.

Wasmtime GitHub notifications bot (Apr 01 2024 at 16:03):

fitzgen requested elliottt for a review on PR #8272.

Wasmtime GitHub notifications bot (Apr 01 2024 at 16:03):

fitzgen commented on PR #8272:

Redirecting to @elliottt

Wasmtime GitHub notifications bot (Apr 04 2024 at 01:03):

elliottt submitted PR review:

Looks good to me!

Wasmtime GitHub notifications bot (Apr 04 2024 at 01:29):

elliottt merged PR #8272.

Last updated: Dec 23 2024 at 12:05 UTC