Stream: git-wasmtime

Topic: wasmtime / PR #8270 Fix the SystemV abi of i128 arguments

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 14:07):

bjorn3 opened PR #8270 from bjorn3:fix_i128_abi to bytecodealliance:main:

i128 arguments must always be passed either fully in registers or fully on the stack according to GCC. LLVM until recently allowed splitting it into a half passed in a register and a half passed on the stack. This was recently fixed. For cg_clif to remain ABI compatible with cg_llvm, it is necessary to apply the same fix to Cranelift.

See also https://blog.rust-lang.org/2024/03/30/i128-layout-update.html

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 14:07):

bjorn3 requested cfallin for a review on PR #8270.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 14:07):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #8270.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 14:32):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 14:32):

bjorn3 created PR review comment:

The godbolt link below is outdated, but until current rustc beta gets promoted to stable I can't make a new permalink for a specific version.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 19:47):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2024 at 20:28):

alexcrichton merged PR #8270.

Last updated: Oct 23 2024 at 20:03 UTC