Wasmtime GitHub notifications bot (Mar 29 2024 at 14:04): Wasmtime GitHub notifications bot (Mar 29 2024 at 14:04):Wang-Zhongqi opened PR #8264 from Wang-Zhongqi:main to bytecodealliance:main:
When disabling sse on x86_64 architecture machines and generating float libcall, incorrect relocation type R_X86_64_8 may be obtained, with the correct type being R_X86_64_64.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 29 2024 at 14:04):Wang-Zhongqi requested wasmtime-core-reviewers for a review on PR #8264.
Wasmtime GitHub notifications bot (Mar 29 2024 at 14:04):Wang-Zhongqi requested alexcrichton for a review on PR #8264.
Wasmtime GitHub notifications bot (Mar 29 2024 at 14:34):alexcrichton edited PR #8264:
When disabling sse on x86_64 architecture machines and generating float libcall, incorrect relocation type R_X86_64_8 may be obtained, with the correct type being R_X86_64_64.
Closes #8255
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 29 2024 at 14:34):alexcrichton submitted PR review:
Thank you for this!
Wasmtime GitHub notifications bot (Mar 29 2024 at 14:44):github-actions[bot] commented on PR #8264:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 29 2024 at 15:01):alexcrichton merged PR #8264.
Last updated: Nov 22 2024 at 16:03 UTC