Stream: git-wasmtime

Topic: wasmtime / PR #8261 Avoid `std::panic` in `wasmtime-runti...

Wasmtime GitHub notifications bot (Mar 28 2024 at 21:45):

alexcrichton opened PR #8261 from alexcrichton:less-std-panic to bytecodealliance:main:

This commit refactors the wasmtime-runtime crate to avoid the std::panic module entirely if it's compiled with panic=abort. From an optimization perspective this is not really required since it'll optimize the same either way with -Cpanic=abort, but avoiding std::panic can help make the code a bit more portable. This refactoring bundles in the catch_unwind with the longjmp of the panic to keep the #[cfg] in one location. Callers are then updated as appropriate.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 28 2024 at 21:45):

alexcrichton requested fitzgen for a review on PR #8261.

Wasmtime GitHub notifications bot (Mar 28 2024 at 21:45):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8261.

Wasmtime GitHub notifications bot (Mar 28 2024 at 21:45):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8261.

Wasmtime GitHub notifications bot (Mar 28 2024 at 22:44):

github-actions[bot] commented on PR #8261:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Apr 01 2024 at 15:54):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 01 2024 at 16:36):

fitzgen merged PR #8261.

Last updated: Nov 22 2024 at 16:03 UTC