Stream: git-wasmtime

Topic: wasmtime / PR #8260 Gate support for the wasm `threads` p...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:47):

alexcrichton requested fitzgen for a review on PR #8260.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:47):

alexcrichton opened PR #8260 from alexcrichton:threads-fatures to bytecodealliance:main:

This commit moves support for the threads proposal behind a new on-by-default Cargo feature: threads. This is intended to support building Wasmtime with fewer runtime dependencies such as those required for the atomic operations on memories.

This additionally adds the gc feature in a few missing places too.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:47):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8260.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:47):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8260.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 21:10):

alexcrichton updated PR #8260.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 21:44):

github-actions[bot] commented on PR #8260:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 21:44):

github-actions[bot] commented on PR #8260:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 08:30):

abrown submitted PR review:

Looks good to me; I assumed all the shared memory and parking spot changes were just refactoring, no functional changes.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 08:57):

abrown merged PR #8260.


Last updated: Dec 23 2024 at 12:05 UTC