Stream: git-wasmtime

Topic: wasmtime / PR #8259 Update Wasmtime's policy on `cargo vet`


view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:49):

alexcrichton requested cfallin for a review on PR #8259.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:49):

alexcrichton opened PR #8259 from alexcrichton:update-vet-policy to bytecodealliance:main:

This was discussed at today's Wasmtime meeting out of some concerns around our current policies. Namely I felt the current state of affairs is not striking the right balance between cost and benefit with our usage of cargo vet. After discussion we've reached consensus around two changes to our cargo vet policy documented here in this PR:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:49):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8259.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:53):

alexcrichton commented on PR #8259:

Some points of note:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:54):

alexcrichton edited a comment on PR #8259:

Some points of note:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:19):

cfallin submitted PR review:

LGTM -- this accurately represents what we came out of the discussion with, I think. Thanks very much for writing up the details!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:19):

cfallin submitted PR review:

LGTM -- this accurately represents what we came out of the discussion with, I think. Thanks very much for writing up the details!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:19):

cfallin created PR review comment:

Let's add some explicit note heres too -- maybe something like "... or don't overwrite your vet entries. Also verify that if the PR branch is rebased or force-pushed, the details of your previously pushed vetting remain the same: e.g., versions were not bumped and descriptive reasons remain the same. If pushing a vetting commit to a contributor's PR and also asking for more changes, request that the contributor make the requested fixes in an additional commit rather than force-pushing a rewritten history, so your existing vetting commit remains untouched. These guidelines make it easier to verify no tampering has occurred."

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 20:20):

cfallin edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 16:26):

alexcrichton updated PR #8259.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 16:27):

alexcrichton has enabled auto merge for PR #8259.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 17:15):

alexcrichton merged PR #8259.


Last updated: Dec 23 2024 at 13:07 UTC