Wasmtime GitHub notifications bot (Mar 28 2024 at 01:05): Wasmtime GitHub notifications bot (Mar 28 2024 at 01:05):alexcrichton opened PR #8250 from alexcrichton:wasmtime-env-no-compile to bytecodealliance:main:
This commit adds a compile-time feature to remove some dependencies of the
wasmtime-environcrate. This compiles out support for compiling modules/components and makes the crate slimmer in terms of amount of code compiled along with its dependencies. Much of this should already have been statically removed by native linkers so this likely won't have any compile-size impact, but it's a nice-to-have in terms of organization.This has a fair bit of shuffling around of code, but apart from renamings and movement there are no major changes here.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:05):alexcrichton requested fitzgen for a review on PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:05):alexcrichton requested wasmtime-core-reviewers for a review on PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:11):alexcrichton updated PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:41):alexcrichton updated PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:57):github-actions[bot] commented on PR #8250:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 28 2024 at 01:57):github-actions[bot] commented on PR #8250:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Mar 28 2024 at 06:11):fitzgen submitted PR review:
Didn't look closely at the actual code blocks, assuming it is all just code motion.
Wasmtime GitHub notifications bot (Mar 28 2024 at 14:56):alexcrichton updated PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 14:56):alexcrichton has enabled auto merge for PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 15:23):alexcrichton updated PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 15:23):alexcrichton has enabled auto merge for PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 15:49):alexcrichton updated PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 15:49):alexcrichton has enabled auto merge for PR #8250.
Wasmtime GitHub notifications bot (Mar 28 2024 at 16:44):alexcrichton merged PR #8250.
Last updated: Nov 22 2024 at 16:03 UTC