Stream: git-wasmtime

Topic: wasmtime / PR #8248 Remove the `winch-tools` crate and CLI

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:18):

alexcrichton requested elliottt for a review on PR #8248.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:18):

alexcrichton requested saulecabrera for a review on PR #8248.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:18):

alexcrichton opened PR #8248 from alexcrichton:remove-winch-executable to bytecodealliance:main:

With all Winch tests moved to tests/disas in #8243 plus the support of wasmtime compile -C compiler=winch this tool should in theory be supplanted nowadays with other alternatives. This commit removes the executable and the winch-filetests support.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:18):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8248.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:18):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8248.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:19):

alexcrichton commented on PR #8248:

I'll note that I'm not wed to this at all, and @saulecabrera or @elliottt or others find this tool useful I'm happy to close this. This can mostly be seen as asking the question of "with today's integration of Winch, is this executable still needed?"

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:34):

saulecabrera submitted PR review:

Makes sense to me. I don't have any particular concerns with removing this crate. Personally I feel that this crate was mostly useful in the early days when Winch was not fully integrated with Wasmtime, then it was mostly kept around for filetests.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:38):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Mar 27 2024 at 15:44):

github-actions[bot] commented on PR #8248:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 27 2024 at 17:29):

alexcrichton merged PR #8248.

Last updated: Nov 22 2024 at 16:03 UTC