Stream: git-wasmtime

Topic: wasmtime / PR #8239 Resolve value aliases in disas tests

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 01:00):

jameysharp opened PR #8239 from jameysharp:resolve-disas-aliases to bytecodealliance:main:

This reverts commit 6c5184809db3a92de4ee0c718c403bedc9a9ff4f, "Cranelift: resolve value aliases when printing CLIF functions (#8214)", then applies the same effect a different way.

In discussion on #8223, we decided to handle this a different way. So I've introduced a method on DataFlowGraph which eliminates all value aliases, and we can call it when necessary. If that function is not called then the CLIF printer should print value aliases the same way it did before #8214.

In this PR, I've specifically called it in disas tests. The changes to write.rs and frontend.rs are from the revert, while the changes to disas.rs are new.

In these tests, value aliases are just clutter that distracts from understanding what code will actually be generated. They may change due to changes in legalization, but that doesn't signal anything about whatever the test was intended to check.

Because the new helper deletes aliases after it's done resolving them, those aliases now disappear from the test expectations. Aside from that, the test expectations are unchanged compared to what #8214 did.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 01:00):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 01:00):

jameysharp requested elliottt for a review on PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 01:00):

jameysharp requested wasmtime-core-reviewers for a review on PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 01:00):

jameysharp requested alexcrichton for a review on PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 02:06):

elliottt submitted PR review:

Awesome! :tada:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 06:21):

jameysharp updated PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 06:21):

jameysharp has enabled auto merge for PR #8239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2024 at 07:02):

jameysharp merged PR #8239.

Last updated: Nov 22 2024 at 16:03 UTC