Stream: git-wasmtime

Topic: wasmtime / PR #8234 cranelift: Only enable winch calling ...

Wasmtime GitHub notifications bot (Mar 25 2024 at 12:43):

saulecabrera opened PR #8234 from saulecabrera:cranelift-winch-call-conv-aarch64 to bytecodealliance:main:

This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/8198; it ensures ensures that the Winch calling convention is only allowed when the architecture is x64.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 25 2024 at 12:43):

saulecabrera requested fitzgen for a review on PR #8234.

Wasmtime GitHub notifications bot (Mar 25 2024 at 12:43):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8234.

Wasmtime GitHub notifications bot (Mar 25 2024 at 12:44):

saulecabrera updated PR #8234.

Wasmtime GitHub notifications bot (Mar 25 2024 at 12:45):

saulecabrera requested elliottt for a review on PR #8234.

Wasmtime GitHub notifications bot (Mar 25 2024 at 14:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 25 2024 at 15:12):

alexcrichton merged PR #8234.

Wasmtime GitHub notifications bot (Mar 25 2024 at 16:23):

elliottt commented on PR #8234:

Thanks for catching this!

Last updated: Nov 22 2024 at 16:03 UTC