Stream: git-wasmtime

Topic: wasmtime / PR #8226 cranelift: Split return instruction e...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 22:34):

elliottt requested cfallin for a review on PR #8226.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 22:34):

elliottt opened PR #8226 from elliottt:main to bytecodealliance:main:

The current approach we're discussing for handling callee-save registers with the tail calling convention involves restoring the frame using the existing backend logic before emitting the jump for the tail call. To prepare for this, this PR splits the ret emission out of gen_epilogue_frame_restore so that it can be used purely to setup the frame for a return or jump.
<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 22:34):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8226.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 22:40):

elliottt requested jameysharp for a review on PR #8226.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 23:01):

cfallin submitted PR review:

Straightforward refactor, LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 23:46):

cfallin merged PR #8226.


Last updated: Dec 23 2024 at 13:07 UTC