elliottt requested cfallin for a review on PR #8226.
elliottt opened PR #8226 from elliottt:main
to bytecodealliance:main
:
The current approach we're discussing for handling callee-save registers with the tail calling convention involves restoring the frame using the existing backend logic before emitting the jump for the tail call. To prepare for this, this PR splits the
ret
emission out ofgen_epilogue_frame_restore
so that it can be used purely to setup the frame for a return or jump.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt requested wasmtime-compiler-reviewers for a review on PR #8226.
elliottt requested jameysharp for a review on PR #8226.
cfallin submitted PR review:
Straightforward refactor, LGTM!
cfallin merged PR #8226.
Last updated: Dec 23 2024 at 13:07 UTC