Stream: git-wasmtime

Topic: wasmtime / PR #8224 Don't take a custom FuncWriter in pre...

Wasmtime GitHub notifications bot (Mar 22 2024 at 20:03):

jameysharp opened PR #8224 from jameysharp:plain-verifier-errors to bytecodealliance:main:

This flexibility is not used anywhere, so let's specialize it.

As far as I can tell, it's never been used since being introduced in https://github.com/bytecodealliance/cranelift/pull/379 in 2018.

@bjorn3, is this used in cg-clif?

Wasmtime GitHub notifications bot (Mar 22 2024 at 20:03):

jameysharp requested fitzgen for a review on PR #8224.

Wasmtime GitHub notifications bot (Mar 22 2024 at 20:03):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8224.

Wasmtime GitHub notifications bot (Mar 22 2024 at 20:06):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 22 2024 at 20:35):

bjorn3 commented on PR #8224:

cg_clif uses it: https://github.com/rust-lang/rustc_codegen_cranelift/blob/593228373d175650bb1033814f515df2e15a489d/src/base.rs#L242

Wasmtime GitHub notifications bot (Mar 22 2024 at 21:03):

jameysharp commented on PR #8224:

Good to know! Then I won't merge this. Thanks for checking!

Wasmtime GitHub notifications bot (Mar 22 2024 at 21:03):

jameysharp closed without merge PR #8224.

Last updated: Nov 22 2024 at 16:03 UTC