Stream: git-wasmtime

Topic: wasmtime / PR #8222 Remove the wasmtime-cranelift-shared ...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 17:44):

elliottt opened PR #8222 from elliottt:trevor/remove-wasmtime-cranelift-shared to bytecodealliance:main:

The wasmtime-cranelift-shared crate is not as useful as it once was, as it's no longer possible to build wasmtime with only winch; winch uses the trampolines generated by cranelift now.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 17:45):

elliottt updated PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 17:45):

github-actions[bot] commented on PR #8222:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 17:54):

elliottt updated PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt has marked PR #8222 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested abrown for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested fitzgen for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested wasmtime-core-reviewers for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested wasmtime-default-reviewers for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested alexcrichton for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:02):

elliottt requested saulecabrera for a review on PR #8222.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:03):

elliottt edited PR #8222:

The wasmtime-cranelift-shared crate is not as useful as it once was, as it's no longer possible to build wasmtime with only winch. This PR merges it back into the wasmtime-cranelift crate.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:29):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 19:55):

alexcrichton merged PR #8222.


Last updated: Dec 23 2024 at 13:07 UTC