encounter opened PR #8220 from encounter:cprop-bswap
to bytecodealliance:main
:
This adds constant propagation for 16-, 32- and 64-bit
bswap
s. I did not addu128
, since it seems like ISLE doesn't have any existing rules for dealing withuimm128
. (Though they could be added, I assume)Please let me know if there's a better approach for the added rules!
encounter requested fitzgen for a review on PR #8220.
encounter requested wasmtime-compiler-reviewers for a review on PR #8220.
alexcrichton submitted PR review:
Thanks for this!
alexcrichton submitted PR review:
Thanks for this!
alexcrichton created PR review comment:
Instead of the
ty_NN
matchers I think you can match$I16
,$I32
, and$I64
here directly which would also avoid the need for a newty_16
(not that it's wrong, just perhaps a nice small cleanup)
alexcrichton commented on PR #8220:
For 128-bit byteswaps that would probably show up through
(bswap (iconcat (iconst ...) (iconst ...)))
but it's also ok to not handle that in this PR too
encounter submitted PR review.
encounter created PR review comment:
Aha, thanks, I knew I was missing something!
encounter updated PR #8220.
alexcrichton submitted PR review.
github-actions[bot] commented on PR #8220:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton merged PR #8220.
Last updated: Dec 23 2024 at 13:07 UTC