Stream: git-wasmtime

Topic: wasmtime / PR #8220 cranelift: Constant propagate `bswap`

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:00):

encounter opened PR #8220 from encounter:cprop-bswap to bytecodealliance:main:

This adds constant propagation for 16-, 32- and 64-bit bswaps. I did not add u128, since it seems like ISLE doesn't have any existing rules for dealing with uimm128. (Though they could be added, I assume)

Please let me know if there's a better approach for the added rules!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:00):

encounter requested fitzgen for a review on PR #8220.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:00):

encounter requested wasmtime-compiler-reviewers for a review on PR #8220.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:11):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:11):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:11):

alexcrichton created PR review comment:

Instead of the ty_NN matchers I think you can match $I16, $I32, and $I64 here directly which would also avoid the need for a new ty_16 (not that it's wrong, just perhaps a nice small cleanup)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:12):

alexcrichton commented on PR #8220:

For 128-bit byteswaps that would probably show up through (bswap (iconcat (iconst ...) (iconst ...))) but it's also ok to not handle that in this PR too

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:13):

encounter submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:13):

encounter created PR review comment:

Aha, thanks, I knew I was missing something!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:14):

encounter updated PR #8220.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:35):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 15:44):

github-actions[bot] commented on PR #8220:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 16:02):

alexcrichton merged PR #8220.

Last updated: Nov 22 2024 at 16:03 UTC