Stream: git-wasmtime

Topic: wasmtime / PR #8217 bump tokio-rustls


view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 09:20):

arlyon opened PR #8217 from arlyon:bump-tokio-rustls to bytecodealliance:main:

Note that rustls is not on the latest minor since tokio-rustls
has not updated yet.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 09:20):

arlyon requested wasmtime-default-reviewers for a review on PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 09:20):

arlyon requested fitzgen for a review on PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2024 at 09:20):

arlyon requested wasmtime-core-reviewers for a review on PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2024 at 22:13):

alexcrichton commented on PR #8217:

Thanks for the PR!

Per project policy we require cargo vet entries for all our dependencies, so we'll project maintainers to vet these new dependencies and push them either as a parallel PR for this to rebase onto or to this PR itself.

I checked initially and these are pretty substantial updates to vet, so to help motivate a bit, can you detail a bit more why this is needed? Is this a "generally good to stay up to date" style PR or perhaps more urgent along the lines of "must fix a bug" or "must only have one library in the crate graph" style problem?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2024 at 19:51):

alexcrichton commented on PR #8217:

I was additionally inspired by this PR and brought up cargo vet at today's Wasmtime meeting which led to https://github.com/bytecodealliance/wasmtime/pull/8259 which will relax the vet rules slightly here.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 16:32):

alexcrichton updated PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 16:33):

alexcrichton commented on PR #8217:

Ok under our new policy for vets I've added necessary exemptions to this PR. I've additionally updated the ureq dependency silghtly to avoid pulling in two versions of rustls/ring.

Thanks for the patience here @arlyon!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 16:33):

alexcrichton has enabled auto merge for PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 17:27):

arlyon commented on PR #8217:

No worries I realise you ended up doing most of the work here so I appreciate the effort. Have a nice weekend! :)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 17:28):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2024 at 18:48):

arlyon edited a comment on PR #8217:

No worries I realise you ended up doing most of the work here so I appreciate the effort. Have a nice weekend! :) For context it was mostly a 'lets get everything over to http@1 for which rustls was a blocker in my dep tree

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 13:53):

alexcrichton updated PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 13:53):

alexcrichton has enabled auto merge for PR #8217.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2024 at 14:52):

alexcrichton merged PR #8217.


Last updated: Dec 23 2024 at 13:07 UTC