Stream: git-wasmtime

Topic: wasmtime / PR #8213 winch: Remove unused functions after ...

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:20):

elliottt opened PR #8213 from elliottt:trevor/winch-remove-clobbers to bytecodealliance:main:

After switching to using wasmtime-cranelift for all trampolines in Winch, there were some functions that became unused in winch-codegen. Additionally, as Winch no longer needs to generate functions with callee-saves, I've removed that functionality.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:21):

elliottt updated PR #8213.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:41):

elliottt has marked PR #8213 as ready for review.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:41):

elliottt requested fitzgen for a review on PR #8213.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:41):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8213.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:41):

elliottt requested saulecabrera for a review on PR #8213.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:43):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Mar 21 2024 at 21:44):

github-actions[bot] commented on PR #8213:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 21 2024 at 22:18):

elliottt merged PR #8213.

Last updated: Nov 22 2024 at 16:03 UTC