Stream: git-wasmtime

Topic: wasmtime / PR #8201 Cranelift: make `bitcast`s between in...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 23:03):

fitzgen opened PR #8201 from fitzgen:issue-8180 to bytecodealliance:main:

This avoids putting multiple conflicting regalloc constraints on values that would otherwise be aliases of each other (one constraint that the value must be in a register as a function argument and another that it must be in a stack slot for a safepoint) by splitting the value in two and each split value getting its own constraint.

Fixes #8180

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 23:03):

fitzgen requested elliottt for a review on PR #8201.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 23:03):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #8201.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2024 at 00:36):

elliottt submitted PR review:

Nice fix! It's interesting that s390x is the only backend that ended up with a new move inserted :thinking:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2024 at 14:40):

fitzgen commented on PR #8201:

Nice fix! It's interesting that s390x is the only backend that ended up with a new move inserted :thinking:

It seems to be the only one that exercised these bitcasts at all.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2024 at 14:41):

fitzgen updated PR #8201.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2024 at 14:41):

fitzgen has enabled auto merge for PR #8201.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2024 at 15:50):

fitzgen merged PR #8201.


Last updated: Dec 23 2024 at 12:05 UTC