Stream: git-wasmtime

Topic: wasmtime / PR #8193 Change `compute_arg_locs` to accept a...

Wasmtime GitHub notifications bot (Mar 20 2024 at 17:02):

elliottt requested fitzgen for a review on PR #8193.

Wasmtime GitHub notifications bot (Mar 20 2024 at 17:02):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8193.

Wasmtime GitHub notifications bot (Mar 20 2024 at 17:02):

elliottt opened PR #8193 from elliottt:trevor/refactor-compute-arg-locs to bytecodealliance:main:

Instead of accepting an IntoIterator for the params argument to compute_arg_locs, take a slice. This simplifies the call-sites a bit, and enables us to avoid shadowing the I type locally within compute_arg_locs.

Co-authored-by: Jamey Sharp <jsharp@fastly.com>

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 20 2024 at 17:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 20 2024 at 18:32):

elliottt merged PR #8193.

Last updated: Dec 23 2024 at 13:07 UTC