Stream: git-wasmtime

Topic: wasmtime / PR #8182 Canonicalize fpromote/fdemote operations

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:23):

alexcrichton opened PR #8182 from alexcrichton:canonicalize-promote-demote to bytecodealliance:main:

This commit changes the strategy implemented in #8146 to canonicalize promotes/demotes of floats to additionally handle #8179.

Closes #8179

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:23):

alexcrichton requested cfallin for a review on PR #8182.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:23):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8182.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:23):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8182.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:23):

alexcrichton requested fitzgen for a review on PR #8182.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:34):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:34):

afonso360 created PR review comment:

Should fvpromote_low also be included here?

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:41):

afonso360 edited PR review comment.

Wasmtime GitHub notifications bot (Mar 19 2024 at 21:11):

alexcrichton updated PR #8182.

Wasmtime GitHub notifications bot (Mar 19 2024 at 21:12):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 19 2024 at 21:12):

alexcrichton created PR review comment:

Good catch! That did indeed previously give different answers for x86 and riscv64 for the test checked in now.

Wasmtime GitHub notifications bot (Mar 20 2024 at 14:15):

afonso360 submitted PR review:

LGTM! :+1:

Wasmtime GitHub notifications bot (Mar 20 2024 at 14:50):

alexcrichton merged PR #8182.

Last updated: Dec 23 2024 at 12:05 UTC