Stream: git-wasmtime

Topic: wasmtime / PR #8181 Add a `ModuleBuilder` type to the `wa...

Wasmtime GitHub notifications bot (Mar 19 2024 at 16:51):

alexcrichton opened PR #8181 from alexcrichton:module-builder to bytecodealliance:main:

This commit is extracted from #8055 and adds a new ModuleBuilder type which is intended to be able to further configure compilation beyond what the constructors of Module already provide. For example in #8055 knobs will be added to process *.dwp files for more debuginfo processing.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 19 2024 at 16:51):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8181.

Wasmtime GitHub notifications bot (Mar 19 2024 at 16:51):

alexcrichton requested fitzgen for a review on PR #8181.

Wasmtime GitHub notifications bot (Mar 19 2024 at 16:51):

alexcrichton commented on PR #8181:

I'll note that while I've called this ModuleBuilder it actually supports components as well, so there's probably a better name for this.

Wasmtime GitHub notifications bot (Mar 19 2024 at 17:44):

alexcrichton updated PR #8181.

Wasmtime GitHub notifications bot (Mar 19 2024 at 19:44):

github-actions[bot] commented on PR #8181:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 20 2024 at 15:21):

fitzgen submitted PR review:

LGTM!

As far as naming goes, the only alternatives I can think of are

• ModuleOrComponentBuilder
• CodeBuilder

Or maybe splitting this type in two in the public API (and sharing an underlying impl) so that we have both a ModuleBuilder and a ComponentBuilder.

Wasmtime GitHub notifications bot (Mar 20 2024 at 15:21):

fitzgen submitted PR review:

LGTM!

As far as naming goes, the only alternatives I can think of are

• ModuleOrComponentBuilder
• CodeBuilder

Or maybe splitting this type in two in the public API (and sharing an underlying impl) so that we have both a ModuleBuilder and a ComponentBuilder.

Wasmtime GitHub notifications bot (Mar 20 2024 at 15:21):

fitzgen created PR review comment:

/// WebAssembly module. Most configuration can use simple constructors such
/// as:

Wasmtime GitHub notifications bot (Mar 20 2024 at 15:21):

fitzgen created PR review comment:

(Don't want to create a weird "advanced" vs not thing where people who consider themselves Serious Wasmtime Users will want to use this without actually having a good reason. Might be overthinking things here.)

Wasmtime GitHub notifications bot (Mar 20 2024 at 15:21):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 20 2024 at 19:38):

alexcrichton commented on PR #8181:

It feels kind of nice being able to configure components/modules in one builder since it's all wasm anyway so I think I'll stick with one for now vs copying APIs, but I'll rename to CodeBuilder as I like that name more.

Wasmtime GitHub notifications bot (Mar 20 2024 at 19:39):

alexcrichton updated PR #8181.

Last updated: Nov 22 2024 at 16:03 UTC