Wasmtime GitHub notifications bot (Mar 18 2024 at 20:41): Wasmtime GitHub notifications bot (Mar 18 2024 at 20:41):cfallin requested abrown for a review on PR #8174.
Wasmtime GitHub notifications bot (Mar 18 2024 at 20:41):cfallin opened PR #8174 from cfallin:fix-pcc-imul to bytecodealliance:main:
In fact, we can even use this fact to infer ranges of the results!
(Previously we had a "default" copy-and-paste across all instruction cases that 64-bit reg writes produced 64 bits of undefinedness and we hadn't tightened the spec here.)
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67436.
Wasmtime GitHub notifications bot (Mar 18 2024 at 20:41):cfallin requested wasmtime-compiler-reviewers for a review on PR #8174.
Wasmtime GitHub notifications bot (Mar 18 2024 at 20:42):cfallin commented on PR #8174:
(Stacked on top of #8173 and will rebase when that merges.)
Wasmtime GitHub notifications bot (Mar 18 2024 at 22:54):cfallin requested wasmtime-core-reviewers for a review on PR #8174.
Wasmtime GitHub notifications bot (Mar 18 2024 at 22:54):cfallin updated PR #8174.
Wasmtime GitHub notifications bot (Mar 18 2024 at 22:54):cfallin requested alexcrichton for a review on PR #8174.
Wasmtime GitHub notifications bot (Mar 18 2024 at 22:54):cfallin updated PR #8174.
Wasmtime GitHub notifications bot (Mar 19 2024 at 00:27):jameysharp submitted PR review:
I think I've confirmed that the widths this commit associates with the outputs of these instructions match the widths in the Intel instruction set reference. I'm willing to believe you that passing those widths to
undefined_resultis the right thing to do.
Wasmtime GitHub notifications bot (Mar 19 2024 at 00:46):cfallin updated PR #8174.
Wasmtime GitHub notifications bot (Mar 19 2024 at 00:46):cfallin has enabled auto merge for PR #8174.
Wasmtime GitHub notifications bot (Mar 19 2024 at 01:30):cfallin merged PR #8174.
Last updated: Dec 23 2024 at 13:07 UTC