Stream: git-wasmtime

Topic: wasmtime / PR #8170 Remove wasm-c-api submodule

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:21):

alexcrichton opened PR #8170 from alexcrichton:vendor-c-api9 to bytecodealliance:main:

This submodule hasn't been updated in ~3 years at this point and we additionally don't need most of the submodule. Instead add a script to copy the files we need and verify in CI that the files are up-to-date.

This also makes using the C API a bit nicer where you don't have to have two include directories with a Wasmtime source tree, just one suffices.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:21):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8170.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:21):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8170.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:21):

alexcrichton requested fitzgen for a review on PR #8170.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:35):

fitzgen submitted PR review:

Nice

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:37):

alexcrichton updated PR #8170.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:38):

alexcrichton has enabled auto merge for PR #8170.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:44):

github-actions[bot] commented on PR #8170:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:25):

alexcrichton merged PR #8170.

Last updated: Dec 23 2024 at 12:05 UTC