Stream: git-wasmtime

Topic: wasmtime / PR #8168 Add `-S inherit-env` for inheriting t...

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:53):

alexcrichton requested fitzgen for a review on PR #8168.

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:53):

alexcrichton opened PR #8168 from alexcrichton:inherit-env to bytecodealliance:main:

This flag is inspired by [Zulip discussion in Rust][zulip] where Wasmtime is used as a test runner. In this situation it's helpful to inherit the entire process environment in one flag rather than having to configure individual tests or individual environment variables.

[zulip]: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Have.20wasm.20tests.20ever.20caused.20problems.20on.20CI.3F/near/427535701

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:53):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8168.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:07):

fitzgen has enabled auto merge for PR #8168.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:39):

fitzgen merged PR #8168.

Last updated: Oct 23 2024 at 20:03 UTC