Stream: git-wasmtime

Topic: wasmtime / PR #8167 x64: Refactor lowerings for `insertlane`

Wasmtime GitHub notifications bot (Mar 18 2024 at 16:20):

alexcrichton requested cfallin for a review on PR #8167.

Wasmtime GitHub notifications bot (Mar 18 2024 at 16:20):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8167.

Wasmtime GitHub notifications bot (Mar 18 2024 at 16:20):

alexcrichton opened PR #8167 from alexcrichton:vec-load-lane-from-memory to bytecodealliance:main:

Going through old PRs I stumbled across #2716 which is quite old at this point. Upon adding the tests to main I see that most of it is actually implemented except for load-lane-from-memory where the lane size is 8 or 16 bits. That requires explicitly opting-in with sinkable_load_exact so this PR now subsumes the tests of #2716 in addition to implementing this missing hole in lowerings.

This refactoring shuffles around where definitions are located to more easily have access to Value to perform the relevant match. The generic vec_insert_lane helper is now gone as well in lieu of direct matches on insertlane lowerings.

Closes #2716

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:14):

cfallin submitted PR review:

LGTM, nice!

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:14):

cfallin submitted PR review:

LGTM, nice!

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:14):

cfallin created PR review comment:

for other ... (lowerings?) -- missing comment line in code motion

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:47):

alexcrichton updated PR #8167.

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:47):

alexcrichton has enabled auto merge for PR #8167.

Wasmtime GitHub notifications bot (Mar 18 2024 at 21:24):

alexcrichton merged PR #8167.

Last updated: Dec 23 2024 at 12:05 UTC