Stream: git-wasmtime

Topic: wasmtime / PR #8166 Rename `-S common` to `-S cli`.

Wasmtime GitHub notifications bot (Mar 18 2024 at 15:00):

sunfishcode requested alexcrichton for a review on PR #8166.

Wasmtime GitHub notifications bot (Mar 18 2024 at 15:00):

sunfishcode requested wasmtime-default-reviewers for a review on PR #8166.

Wasmtime GitHub notifications bot (Mar 18 2024 at 15:00):

sunfishcode requested wasmtime-core-reviewers for a review on PR #8166.

Wasmtime GitHub notifications bot (Mar 18 2024 at 15:00):

sunfishcode opened PR #8166 from sunfishcode:sunfishcode/cli to bytecodealliance:main:

The "common" in -S common came from "wasi-common" which came from the idea of having code in common between Wasmtime, Lucet, and others. It doesn't have a clear meaning for end users, and has a risk of being interpreted as "common" functionality that's generally available everywhere.

This PR renames -S common to -S cli, and documents it as including the WASI CLI APIs, to clarify its purpose -S common is still accepted, with a warning.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:59):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:59):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:59):

alexcrichton created PR review comment:

Could this be omitted for the time being? I figure it might be good to let the change percolate before warnings start showing up.

Wasmtime GitHub notifications bot (Mar 18 2024 at 17:59):

alexcrichton created PR review comment:

Mind updating this following the same format as below with bullets and a link to the PR?

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:19):

sunfishcode updated PR #8166.

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:24):

sunfishcode updated PR #8166.

Wasmtime GitHub notifications bot (Mar 18 2024 at 21:02):

sunfishcode merged PR #8166.

Last updated: Dec 23 2024 at 12:05 UTC