Stream: git-wasmtime

Topic: wasmtime / PR #8162 Refactor the `MemFlags` internal repr...

Wasmtime GitHub notifications bot (Mar 18 2024 at 04:13):

alexcrichton opened PR #8162 from alexcrichton:refactor-mem-flags to bytecodealliance:main:

This commit refactors the internal MemFlags bits to be not just flags.
Instead some bits are now grouped together and interpreted as a unit.
This enables two primary API changes:

• First the heap/table/vmctx split is now represented as an "alias
  region" which is set as an enum. This means that all MemFlags carry
  an Option<AliasRegion> internally.

• Second trapping state is now represented as an Option<TrapCode>.
  This means that notrap is no longer a flag and tabletrap is no
  longer a flag. This does enable storing arbitrary trap codes though so
  long as they aren't TrapCode::User(_).

The main purpose of this commit is to enable using more trap codes with
MemFlags for when a segfault is detected. For example with https://github.com/bytecodealliance/wasmtime/issues/5291 we
want a segfault to indicate a call-to-null, which is not currently
covered by MemFlags.

Wasmtime GitHub notifications bot (Mar 18 2024 at 04:13):

alexcrichton requested fitzgen for a review on PR #8162.

Wasmtime GitHub notifications bot (Mar 18 2024 at 04:13):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8162.

Wasmtime GitHub notifications bot (Mar 18 2024 at 04:13):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8162.

Wasmtime GitHub notifications bot (Mar 18 2024 at 08:33):

jameysharp created PR review comment:

I think this comment no longer applies; the "Errors" section below covers semantic errors, set_by_name doesn't return false for them any more.

    /// name.

Wasmtime GitHub notifications bot (Mar 18 2024 at 08:33):

jameysharp submitted PR review:

This looks great, after one minor doc-comment fix I think. Very clear and reviewable, thank you!

Wasmtime GitHub notifications bot (Mar 18 2024 at 08:33):

jameysharp submitted PR review:

This looks great, after one minor doc-comment fix I think. Very clear and reviewable, thank you!

Wasmtime GitHub notifications bot (Mar 18 2024 at 14:55):

alexcrichton updated PR #8162.

Wasmtime GitHub notifications bot (Mar 18 2024 at 14:55):

alexcrichton has enabled auto merge for PR #8162.

Wasmtime GitHub notifications bot (Mar 18 2024 at 15:39):

alexcrichton merged PR #8162.

Last updated: Oct 23 2024 at 20:03 UTC