Wasmtime GitHub notifications bot (Mar 16 2024 at 18:02): Wasmtime GitHub notifications bot (Mar 16 2024 at 18:02):saulecabrera opened PR #8157 from saulecabrera:winch-plumb-heap-types to bytecodealliance:main:
This commit is a follow-up to https://github.com/bytecodealliance/wasmtime/pull/8059 (in which I forgot to include the heap types for the other checks, e.g. overflow). Instead of arbitrarily using the target's pointer size, it derives the use from the heap information, in order to do bounds check calculations, this enables checking the right limits.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:02):saulecabrera requested abrown for a review on PR #8157.
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:02):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8157.
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:02):saulecabrera requested elliottt for a review on PR #8157.
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:05):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:45):github-actions[bot] commented on PR #8157:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 16 2024 at 18:47):saulecabrera merged PR #8157.
Last updated: Dec 23 2024 at 12:05 UTC