Stream: git-wasmtime

Topic: wasmtime / PR #8156 winch: Correctly handle the result of...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2024 at 13:45):

saulecabrera opened PR #8156 from saulecabrera:winch-handle-memory-grow to bytecodealliance:main:

This commit correctly handles the result of the memory grow builtin function. Previously, it was assumed that the result of memory grow must be of the the target's pointer type, which doesn't accurately represent the address space covered by the memory type.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2024 at 13:45):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8156.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2024 at 13:45):

saulecabrera requested elliottt for a review on PR #8156.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 16 2024 at 14:44):

github-actions[bot] commented on PR #8156:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 18:25):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 18:51):

alexcrichton commented on PR #8156:

Ok Mr GitHub I'll lay off for a bit

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2024 at 20:06):

alexcrichton merged PR #8156.


Last updated: Dec 23 2024 at 12:05 UTC