Stream: git-wasmtime

Topic: wasmtime / PR #8149 Enhance test around stack overflow

Wasmtime GitHub notifications bot (Mar 15 2024 at 17:56):

alexcrichton opened PR #8149 from alexcrichton:enhance-stack-overflow-testing to bytecodealliance:main:

This commit enhances the host_always_has_some_stack a bit in light of some thinking around #8135. Notably this test ensures that the host itself never segfaults even if the wasm exhausts all of its stack. There are a number of ways that we can exit out to the host, though, and only one was tested previously. This commit updates to ensure more cases are covered.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 15 2024 at 17:57):

alexcrichton requested fitzgen for a review on PR #8149.

Wasmtime GitHub notifications bot (Mar 15 2024 at 17:57):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8149.

Wasmtime GitHub notifications bot (Mar 15 2024 at 18:20):

alexcrichton updated PR #8149.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:42):

fitzgen submitted PR review:

LGTM modulo comment below.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:42):

fitzgen submitted PR review:

LGTM modulo comment below.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:42):

fitzgen created PR review comment:

                    (drop (memory.grow (i32.const 0)))

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:42):

fitzgen created PR review comment:

We never store to HITS; I assume we did at one point in time, but not anymore. Therefore, this isn't really testing what the comment says it is.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:47):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:47):

alexcrichton created PR review comment:

Oh the store is just below in test_host_stack

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:50):

alexcrichton updated PR #8149.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:50):

alexcrichton has enabled auto merge for PR #8149.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:51):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:51):

fitzgen created PR review comment:

D'oh

Wasmtime GitHub notifications bot (Mar 18 2024 at 19:52):

alexcrichton merged PR #8149.

Last updated: Dec 23 2024 at 12:05 UTC