Stream: git-wasmtime

Topic: wasmtime / PR #8144 Turn most cranelift-wasm wasmtests in...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:47):

jameysharp requested fitzgen for a review on PR #8144.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:47):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8144.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:47):

jameysharp opened PR #8144 from jameysharp:more-wasm-tests to bytecodealliance:main:

These tests mostly verify compiler behavior for specific WebAssembly constructs or small combinations.

Currently they're only tested to make sure that cranelift-wasm doesn't crash or report an error. But they'd be even more useful if we track what CLIF we actually produce from Wasmtime.

So I'm moving them to the new disas test framework and adding basic CLIF test expectations for them.

I've excluded the .wat files which were produced by Emscripten or Rust, because they're very large and their compiled CLIF is not very interesting to look at.

For review purposes, the first commit moves the files and the second commit adds the test expectations to them.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:47):

jameysharp requested wasmtime-core-reviewers for a review on PR #8144.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:09):

alexcrichton submitted PR review:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:55):

alexcrichton merged PR #8144.


Last updated: Dec 23 2024 at 12:05 UTC