alexcrichton opened PR #8143 from alexcrichton:remove-some-more-test-bits
to bytecodealliance:main
:
Some more cleanup enabled through #8140 and #8129
alexcrichton requested cfallin for a review on PR #8143.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8143.
alexcrichton requested fitzgen for a review on PR #8143.
alexcrichton requested wasmtime-core-reviewers for a review on PR #8143.
alexcrichton requested wasmtime-default-reviewers for a review on PR #8143.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
Idle thought: if the test is now a Wasmtime test, should this environment variable be something like
WASMTIME_TEST_BLESS
?(Smallest of small bikeshed color comments, fine either way, just a thought...)
bjorn3 submitted PR review.
bjorn3 created PR review comment:
Can the cranelift-wasm and wasmparser dependencies be removed from filetests?
alexcrichton updated PR #8143.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Oh indeed they can!
alexcrichton updated PR #8143.
alexcrichton has enabled auto merge for PR #8143.
alexcrichton updated PR #8143.
alexcrichton updated PR #8143.
alexcrichton updated PR #8143.
alexcrichton commented on PR #8143:
This hit an unusual error on CI which looked like:
Running tests/filetests.rs (target/riscv64gc-unknown-linux-gnu/debug/deps/filetests-9d21d101a4f160f6) thread 'worker #2' panicked at cranelift/jit/src/backend.rs:342:40: can't resolve libcall ceilf
Apparently the removal of the wasm-related dependencies also removed all dependencies on libm for riscv64 which meant that tests were failing as a dlsym for various libcall symbols was failing. I just added a commit which forces linking to libm by referring to a symbol and calling it.
alexcrichton has enabled auto merge for PR #8143.
alexcrichton merged PR #8143.
Last updated: Dec 23 2024 at 13:07 UTC