Stream: git-wasmtime

Topic: wasmtime / PR #8143 Remove some more cranelift-filetest w...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton opened PR #8143 from alexcrichton:remove-some-more-test-bits to bytecodealliance:main:

Some more cleanup enabled through #8140 and #8129

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton requested cfallin for a review on PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton requested fitzgen for a review on PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:01):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:25):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:25):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 01:25):

cfallin created PR review comment:

Idle thought: if the test is now a Wasmtime test, should this environment variable be something like WASMTIME_TEST_BLESS?

(Smallest of small bikeshed color comments, fine either way, just a thought...)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 06:41):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 06:41):

bjorn3 created PR review comment:

Can the cranelift-wasm and wasmparser dependencies be removed from filetests?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:03):

alexcrichton updated PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:03):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:03):

alexcrichton created PR review comment:

Oh indeed they can!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:03):

alexcrichton updated PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:04):

alexcrichton has enabled auto merge for PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:27):

alexcrichton updated PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:27):

alexcrichton updated PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:51):

alexcrichton updated PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:53):

alexcrichton commented on PR #8143:

This hit an unusual error on CI which looked like:

     Running tests/filetests.rs (target/riscv64gc-unknown-linux-gnu/debug/deps/filetests-9d21d101a4f160f6)
thread 'worker #2' panicked at cranelift/jit/src/backend.rs:342:40:
can't resolve libcall ceilf

Apparently the removal of the wasm-related dependencies also removed all dependencies on libm for riscv64 which meant that tests were failing as a dlsym for various libcall symbols was failing. I just added a commit which forces linking to libm by referring to a symbol and calling it.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 15:53):

alexcrichton has enabled auto merge for PR #8143.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2024 at 17:34):

alexcrichton merged PR #8143.

Last updated: Nov 22 2024 at 17:03 UTC