Stream: git-wasmtime

Topic: wasmtime / PR #8138 Enable `-Scommon` by default for `was...

Wasmtime GitHub notifications bot (Mar 14 2024 at 20:32):

alexcrichton opened PR #8138 from alexcrichton:serve-common-on-by-default to bytecodealliance:main:

This commit enables more WASI interfaces by default with wasmtime serve, notably through the use of the -Scommon flag. This means that the interfaces supported by wasmtime serve are the same as wasmtime run by default.

To fully implement this there's a number of refactorings here:

• More flags like --dir and --env are moved into RunCommon to be shared between wasmtime serve and wasmtime run, meaning that the serve command can now configure environment variables.

• A small test has been added as well as infrastructure for running tests with wasmtime serve itself. Previously there were no tests that executed wasmtime serve.

• The test_programs crate had a small refactoring to avoid double-generation of http bindings.

Closes #8086

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 14 2024 at 20:32):

alexcrichton requested fitzgen for a review on PR #8138.

Wasmtime GitHub notifications bot (Mar 14 2024 at 20:32):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8138.

Wasmtime GitHub notifications bot (Mar 14 2024 at 22:21):

tschneidereit commented on PR #8138:

Thank you for doing this, and fully aligning it with run while you were at it! :heart:

Wasmtime GitHub notifications bot (Mar 18 2024 at 18:50):

fitzgen requested sunfishcode for a review on PR #8138.

Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton closed without merge PR #8138.

Wasmtime GitHub notifications bot (Apr 01 2024 at 23:47):

alexcrichton commented on PR #8138:

I've extracted refactorings here to https://github.com/bytecodealliance/wasmtime/pull/8279 and will leave the question of defaults to https://github.com/bytecodealliance/wasmtime/issues/8086

Last updated: Nov 22 2024 at 16:03 UTC