Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54): Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):uweigand opened PR #8136 from uweigand:s390x-fix-vecabi to bytecodealliance:main:
On s390x we support ABIs with little-endian or big-endian vector lane ordering. When calling to function with a different lane order, vector arguments need to be lane-swapped. This currently happens for arguments passed in registers, but not for those passed on the stack - that is a bug.
Fixed by swapping stack arguments as well.
Fixes https://github.com/bytecodealliance/wasmtime/issues/8132
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):uweigand requested cfallin for a review on PR #8136.
Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):uweigand requested wasmtime-compiler-reviewers for a review on PR #8136.
Wasmtime GitHub notifications bot (Mar 14 2024 at 18:07):cfallin submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (Mar 14 2024 at 18:07):cfallin has enabled auto merge for PR #8136.
Wasmtime GitHub notifications bot (Mar 14 2024 at 18:44):cfallin merged PR #8136.
Last updated: Oct 23 2024 at 20:03 UTC