Stream: git-wasmtime

Topic: wasmtime / PR #8136 s390x: Fix ABI vector-lane swap for o...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):

uweigand opened PR #8136 from uweigand:s390x-fix-vecabi to bytecodealliance:main:

On s390x we support ABIs with little-endian or big-endian vector lane ordering. When calling to function with a different lane order, vector arguments need to be lane-swapped. This currently happens for arguments passed in registers, but not for those passed on the stack - that is a bug.

Fixed by swapping stack arguments as well.

Fixes https://github.com/bytecodealliance/wasmtime/issues/8132

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):

uweigand requested cfallin for a review on PR #8136.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 17:54):

uweigand requested wasmtime-compiler-reviewers for a review on PR #8136.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:07):

cfallin submitted PR review:

LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:07):

cfallin has enabled auto merge for PR #8136.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:44):

cfallin merged PR #8136.


Last updated: Dec 23 2024 at 13:07 UTC