Wasmtime GitHub notifications bot (Mar 13 2024 at 21:46): Wasmtime GitHub notifications bot (Mar 13 2024 at 21:46):jameysharp requested cfallin for a review on PR #8124.
Wasmtime GitHub notifications bot (Mar 13 2024 at 21:46):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8124.
Wasmtime GitHub notifications bot (Mar 13 2024 at 21:46):jameysharp opened PR #8124 from jameysharp:stop-doing-cranelift-tables to bytecodealliance:main:
Wasmtime no longer needs any of this infrastructure and neither should anybody else.
This diff is nearly identical to @bjorn3's version of the same change, except I didn't remove Uimm64, which has started being used in other places. I forgot bjorn3 had already tackled this part until after I was already done, but it's reassuring that we both made the same changes.
https://github.com/bjorn3/wasmtime/commit/fb82ccb3948e949641a6d9581aa84472f68f97b8
Fixes #5532
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 13 2024 at 23:23):cfallin submitted PR review:
LGTM! This is good code motion that makes Cranelift maintenance easier while moving tables up a layer where they can benefit from other opts too. Thanks for pushing it forward.
Wasmtime GitHub notifications bot (Mar 14 2024 at 16:11):jameysharp merged PR #8124.
Last updated: Nov 22 2024 at 16:03 UTC