afonso360 opened PR #8123 from afonso360:riscv-fix-smin
to bytecodealliance:main
:
:wave: Hey,
This PR fixes #8114
We were accidentally using the
max
opcode in themin
helper when using theZbb
extension. This wasn't caught by testing since we never enabled thesmin
tests with theZbb
extension enabled.Furthermore this should have been caught by fuzzing, but we also don't regularly fuzz RISC-V. (And I haven't ran it manually in quite a while)
afonso360 requested elliottt for a review on PR #8123.
afonso360 requested wasmtime-compiler-reviewers for a review on PR #8123.
afonso360 edited PR #8123:
:wave: Hey,
This PR fixes #8114
We were accidentally using the
max
opcode in themin
helper when using theZbb
extension. This wasn't caught by testing since we never enabled thesmin
tests with theZbb
extension enabled.Furthermore this should have been caught by fuzzing, but we also don't regularly fuzz RISC-V. (And I haven't ran it manually in quite a while).
Thanks for reporting it @candymate, let me know if you find anything else!
alexcrichton submitted PR review.
alexcrichton has enabled auto merge for PR #8123.
alexcrichton merged PR #8123.
Last updated: Dec 23 2024 at 13:07 UTC