Stream: git-wasmtime

Topic: wasmtime / PR #8123 riscv64: Emit the correct `min` op in...

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:05):

afonso360 opened PR #8123 from afonso360:riscv-fix-smin to bytecodealliance:main:

:wave: Hey,

This PR fixes #8114

We were accidentally using the max opcode in the min helper when using the Zbb extension. This wasn't caught by testing since we never enabled the smin tests with the Zbb extension enabled.

Furthermore this should have been caught by fuzzing, but we also don't regularly fuzz RISC-V. (And I haven't ran it manually in quite a while)

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:05):

afonso360 requested elliottt for a review on PR #8123.

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:05):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #8123.

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:07):

afonso360 edited PR #8123:

:wave: Hey,

This PR fixes #8114

We were accidentally using the max opcode in the min helper when using the Zbb extension. This wasn't caught by testing since we never enabled the smin tests with the Zbb extension enabled.

Furthermore this should have been caught by fuzzing, but we also don't regularly fuzz RISC-V. (And I haven't ran it manually in quite a while).

Thanks for reporting it @candymate, let me know if you find anything else!

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:10):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 13 2024 at 20:10):

alexcrichton has enabled auto merge for PR #8123.

Wasmtime GitHub notifications bot (Mar 13 2024 at 21:02):

alexcrichton merged PR #8123.

Last updated: Nov 22 2024 at 17:03 UTC