Wasmtime GitHub notifications bot (Mar 13 2024 at 03:17): Wasmtime GitHub notifications bot (Mar 13 2024 at 03:17):alexcrichton requested fitzgen for a review on PR #8111.
Wasmtime GitHub notifications bot (Mar 13 2024 at 03:17):alexcrichton requested wasmtime-core-reviewers for a review on PR #8111.
Wasmtime GitHub notifications bot (Mar 13 2024 at 03:17):alexcrichton requested wasmtime-default-reviewers for a review on PR #8111.
Wasmtime GitHub notifications bot (Mar 13 2024 at 03:17):alexcrichton opened PR #8111 from alexcrichton:ci-vendor-wits to bytecodealliance:main:
This is a follow-up to #7929 where it was concluded that we want to retain textual WIT files in this repository. Currently today we have no automated checks for vendoring and re-vendoring requires hand-editing. To help incrementally improve this situation this commit adds a script to do all the vendoring for us. This way CI can verify that everything is generated with respect to the output of this script.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 13 2024 at 13:28):fitzgen submitted PR review:
:tada:
Wasmtime GitHub notifications bot (Mar 13 2024 at 13:28):fitzgen created PR review comment:
Maybe check
git diff --exit-codebefore this and exit the script before doing any permanent deletions if there are local, uncommitted changes? Just to be safe.
Wasmtime GitHub notifications bot (Mar 13 2024 at 13:28):fitzgen submitted PR review:
:tada:
Wasmtime GitHub notifications bot (Mar 13 2024 at 13:28):fitzgen created PR review comment:
And maybe the same for how to update tag/WASI version?
May make sense to put all the "config" variables at the top of the script so that folks can update them without having to read the whole script and learn the implementation just to eg add support for WASI-foo to the script.
Wasmtime GitHub notifications bot (Mar 13 2024 at 13:28):fitzgen created PR review comment:
Comment for this variable describing how to add new WASI repos/WITs to vendor, either here or at the top?
Wasmtime GitHub notifications bot (Mar 13 2024 at 15:19):alexcrichton updated PR #8111.
Wasmtime GitHub notifications bot (Mar 13 2024 at 15:20):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 13 2024 at 15:20):alexcrichton created PR review comment:
Personally I'd prefer to leave that to CI because it makes editing a script like this hard to work with and git is otherwise pretty good about making sure things aren't overwritten.
Wasmtime GitHub notifications bot (Mar 13 2024 at 18:53):alexcrichton merged PR #8111.
Last updated: Oct 23 2024 at 20:03 UTC