Stream: git-wasmtime

Topic: wasmtime / PR #8109 winch: Switch to using cranelift for ...

Wasmtime GitHub notifications bot (Mar 12 2024 at 23:56):

elliottt opened PR #8109 from elliottt:trevor/winch-remove-trampolines to bytecodealliance:main:

Remove the winch MacroAssembler-based trampolines, and reuse the trampoline-generation from the wasmtime-cranlift crate instead.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 13 2024 at 00:01):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 01:03):

github-actions[bot] commented on PR #8109:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 13 2024 at 15:17):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:47):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt has marked PR #8109 as ready for review.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt requested cfallin for a review on PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt requested wasmtime-core-reviewers for a review on PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt requested alexcrichton for a review on PR #8109.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Mar 13 2024 at 23:49):

elliottt created PR review comment:

If this PR gets reverted, please preserve this change.

Wasmtime GitHub notifications bot (Mar 14 2024 at 00:01):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 14 2024 at 00:05):

elliottt requested saulecabrera for a review on PR #8109.

Wasmtime GitHub notifications bot (Mar 14 2024 at 00:05):

elliottt edited PR #8109:

Remove the winch MacroAssembler-based trampolines, and reuse the trampoline-generation from the wasmtime-cranlift crate instead.

Fixes #8098
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 14 2024 at 08:41):

saulecabrera submitted PR review:

LGTM, thanks!

One thing that I wanted to note: Winch is still missing support for emit_trampolines_for_array_call_host_func, would it make sense to implement that function in this PR? I think a follow-up also works!

Wasmtime GitHub notifications bot (Mar 15 2024 at 20:37):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 18 2024 at 21:34):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 19 2024 at 18:35):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 19 2024 at 18:43):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Mar 19 2024 at 18:43):

elliottt created PR review comment:

I merged this separately, so we can ignore this comment now.

Wasmtime GitHub notifications bot (Mar 20 2024 at 16:44):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 20 2024 at 16:46):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 20 2024 at 17:03):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 20 2024 at 19:46):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 21 2024 at 00:10):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 21 2024 at 00:39):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 21 2024 at 00:40):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 21 2024 at 16:09):

elliottt updated PR #8109.

Wasmtime GitHub notifications bot (Mar 21 2024 at 18:25):

elliottt merged PR #8109.

Last updated: Dec 23 2024 at 12:05 UTC