Stream: git-wasmtime

Topic: wasmtime / PR #8099 x64: Implement fallback for fcvt_from...

Wasmtime GitHub notifications bot (Mar 12 2024 at 15:49):

alexcrichton opened PR #8099 from alexcrichton:x64-fcvt-from-sint-f64x2 to bytecodealliance:main:

This instruction was previously unimplemented in Cranelift as pointed out in #8084. While a fallback for fcvt_from_uint was implemented in #7919 I forgot to do the same for the signed version. This commit adds a fallback that decomposes the input into two scalars and converts each individually, then reassembling the result.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 12 2024 at 15:49):

alexcrichton requested elliottt for a review on PR #8099.

Wasmtime GitHub notifications bot (Mar 12 2024 at 15:49):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8099.

Wasmtime GitHub notifications bot (Mar 12 2024 at 16:11):

elliottt submitted PR review:

Looks good!

Wasmtime GitHub notifications bot (Mar 12 2024 at 17:46):

alexcrichton merged PR #8099.

Last updated: Nov 22 2024 at 17:03 UTC