Stream: git-wasmtime

Topic: wasmtime / PR #8071 Clear borrow tracking converting `Res...

Wasmtime GitHub notifications bot (Mar 08 2024 at 22:06):

alexcrichton requested fitzgen for a review on PR #8071.

Wasmtime GitHub notifications bot (Mar 08 2024 at 22:06):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8071.

Wasmtime GitHub notifications bot (Mar 08 2024 at 22:06):

alexcrichton opened PR #8071 from alexcrichton:clear-borrow-tracking-on-convert to bytecodealliance:main:

This commit clears out the dynamic tracking of borrows within a ResourceAny when it's converted to a Resource<T>. The Resource<T> type doesn't participate in this borrow tracking in the same way as ResourceAny because it's assumed that hosts are well-behaved in this regard. This means that the conversion here should respect these guarantees of Resource<T> and auto-clear the borrow tracking.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 08 2024 at 22:06):

alexcrichton requested dicej for a review on PR #8071.

Wasmtime GitHub notifications bot (Mar 08 2024 at 22:44):

github-actions[bot] commented on PR #8071:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 08 2024 at 23:20):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Mar 09 2024 at 00:12):

alexcrichton merged PR #8071.

Last updated: Dec 23 2024 at 12:05 UTC