Stream: git-wasmtime

Topic: wasmtime / PR #8066 wasmtime-c-api: switch from wasi-comm...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:30):

pchickey opened PR #8066 from bytecodealliance:pch/wasmtime_wasi_c_api to bytecodealliance:main:

Based on #8053

This PR switches the wasmtime-c-api from using wasi-common to wasmtime-wasi.

The c-api still only exposes WASI P1 support to the guests - this isn't attempting to solve the problem of exposing components and WASI P2 on the c-api. It is only changing the implementation used under the hood so that we can push wasi-common into maintenance mode.

This PR removes the wasi_config_preopen_socket symbol from the c-api. It should be deployed as part of release-20.0.0 (not backported to 19) so that users get 1 release of deprecation warning via https://github.com/bytecodealliance/wasmtime/pull/8064 . The idea of a preopen socket is a weird corner of P1 that never got any appropriate testing in the wasmtime tree, and doesnt have a translation in the P2 world. I sought out if there were any users of that part of the P1 / wasi-common code, because the company that contributed it is now defunct, and I never found any users. The warning in #8064 may alert us to some and the symbol going away in this PR may as well.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:30):

pchickey requested alexcrichton for a review on PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:30):

pchickey requested wasmtime-core-reviewers for a review on PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:30):

pchickey requested elliottt for a review on PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 02:44):

github-actions[bot] commented on PR #8066:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasi", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 15:28):

pchickey requested wasmtime-default-reviewers for a review on PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 15:28):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 17:39):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 17:41):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:15):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:26):

elliottt submitted PR review:

This looks good to me!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:26):

elliottt requested alexcrichton for a review on PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:06):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:06):

alexcrichton created PR review comment:

I think the previous version didn't buffer things here, so could this keep the unbuffered versions?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:06):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:31):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:32):

elliottt updated PR #8066.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:45):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 21:37):

elliottt merged PR #8066.


Last updated: Dec 23 2024 at 12:05 UTC