Stream: git-wasmtime

Topic: wasmtime / PR #8065 Fix generating bindings for dead code

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:28):

alexcrichton opened PR #8065 from alexcrichton:fix-gen-bindings-for-dead-code to bytecodealliance:main:

This commit fixes a bindgen problem where dead types, which had no generated bindings, could be referred to from other dead types, which did have generated bindings. The fix is to not generate code for dead types at all by fixing how type information is analyzed.

Closes #8057

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:28):

alexcrichton requested fitzgen for a review on PR #8065.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 00:28):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8065.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 03:34):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 03:34):

pchickey created PR review comment:

Not clear to me how this tests liveness since both interfaces are part of the imports?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 15:19):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 15:19):

alexcrichton created PR review comment:

Ah good point, I should clarify, liveness is calculated in terms of what's used by imported/exported functions. No function actually uses dead-type or v but live-type is used by a function, and so we don't generate bindings for dead-type and this PR fixes a bug where we previously tried to generate bindings for v despite nothing using it.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2024 at 03:44):

alexcrichton requested dicej for a review on PR #8065.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 03:17):

alexcrichton requested elliottt for a review on PR #8065.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:06):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:06):

elliottt created PR review comment:

Does doing this step first mean that the calls to self.type_info in type_info_func should never traverse the whole type (due to the early exit if the entry exists already)?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 18:06):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 19:46):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 19:46):

alexcrichton created PR review comment:

Not for this, but the below bits would still need it for setting the owned/borrowed bits.

It's probably best to switching this to LiveSet one day as a future refactoring

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2024 at 20:15):

alexcrichton merged PR #8065.

Last updated: Dec 23 2024 at 13:07 UTC