jameysharp edited PR #8063.
jameysharp has marked PR #8063 as ready for review.
jameysharp requested fitzgen for a review on PR #8063.
jameysharp requested wasmtime-compiler-reviewers for a review on PR #8063.
jameysharp requested wasmtime-core-reviewers for a review on PR #8063.
fitzgen submitted PR review:
Nice!
fitzgen submitted PR review:
Nice!
fitzgen created PR review comment:
And apologies if tihs already existed. I think we can clean up a tiny bit of complexity here, if that was the case.
fitzgen created PR review comment:
Not 100% convinced it is worth adding the power-of-2 optimization here, since our mid-end rules should definitely already handle this. I think this file should focus on just (a) the correctness of the bounds checks and (b) optimizations to the bounds checks that rely on knowledge of the Wasm table and its limits that the mid-end can't possibly know.
jameysharp submitted PR review.
jameysharp created PR review comment:
Yeah, I considered removing that in favor of relying on the corresponding egraph optimizations, but decided to keep it since it was in the original. I'd prefer to land it in this form to avoid bigger changes to the filetests, where I specifically have not turned on the egraph pass so it's more clear what's being generated, but I wouldn't be upset about removing this later.
jameysharp merged PR #8063.
Last updated: Dec 23 2024 at 12:05 UTC