wasmtime / PR #8063 cranelift-wasm: Stop using table_addr... · git-wasmtime

Not 100% convinced it is worth adding the power-of-2 optimization here, since our mid-end rules should definitely already handle this. I think this file should focus on just (a) the correctness of the bounds checks and (b) optimizations to the bounds checks that rely on knowledge of the Wasm table and its limits that the mid-end can't possibly know.

Wasmtime GitHub notifications bot (Mar 13 2024 at 21:12):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 13 2024 at 21:12):

jameysharp created PR review comment:

Yeah, I considered removing that in favor of relying on the corresponding egraph optimizations, but decided to keep it since it was in the original. I'd prefer to land it in this form to avoid bigger changes to the filetests, where I specifically have not turned on the egraph pass so it's more clear what's being generated, but I wouldn't be upset about removing this later.

Wasmtime GitHub notifications bot (Mar 13 2024 at 21:39):

jameysharp merged PR #8063.

Last updated: Nov 22 2024 at 17:03 UTC