Stream: git-wasmtime

Topic: wasmtime / PR #8062 Remove type information from `wasmtim...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 23:11):

alexcrichton requested dicej for a review on PR #8062.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 23:11):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8062.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 23:11):

alexcrichton opened PR #8062 from alexcrichton:untyped-val to bytecodealliance:main:

This commit is a large refactor of the Val type as used with components to remove inherent type information present currently. The Val type is now only an AST of what a component model value looks like and cannot fully describe the type that it is without further context. For example enums only store the case that's being used, not the full set of cases.

The motivation for this commit is to make it simpler to use and construct Val, especially in the face of resources. Some problems solved here are:

It's worth pointing out that Val as-is is a pretty inefficient representation of component model values, for example flags are stored as a list of strings. While semantically correct this is quite inefficient for most purposes other than "get something working". To that extent my goal is to, in the future, add traits that enable building a custom user-defined Val (of sorts), but still dynamically. This should enable embedders to opt-in to a more efficient representation that relies on contextual knowledge.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 23:11):

alexcrichton requested fitzgen for a review on PR #8062.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 01:03):

github-actions[bot] commented on PR #8062:

Subscribe to Label Action

cc @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 01:22):

lann submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 15:33):

fitzgen submitted PR review:

LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2024 at 15:59):

fitzgen merged PR #8062.


Last updated: Dec 23 2024 at 12:05 UTC