Stream: git-wasmtime

Topic: wasmtime / PR #8060 Fix `wasmtime settings` command.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:07):

peterhuene requested wasmtime-core-reviewers for a review on PR #8060.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:07):

peterhuene requested fitzgen for a review on PR #8060.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:07):

peterhuene opened PR #8060 from peterhuene:fix-settings-command to bytecodealliance:main:

Currently the settings command panics because the tunables are not set in the compiler builder.

This commit creates a default tunables based on either the target triple passed on the command line or uses the default for the host.

Fixes #8058.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:11):

alexcrichton submitted PR review:

Oh dear sorry about the regression!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:11):

alexcrichton has enabled auto merge for PR #8060.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:14):

peterhuene updated PR #8060.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2024 at 16:57):

alexcrichton merged PR #8060.

Last updated: Dec 23 2024 at 12:05 UTC