Wasmtime GitHub notifications bot (Mar 07 2024 at 01:59): Wasmtime GitHub notifications bot (Mar 07 2024 at 01:59):elliottt opened PR #8056 from elliottt:trevor/cranelift-calling-winch to bytecodealliance:main:
Add a
Winchcalling convention to cranelift that has no callee saves, and
clobbers everything. This will enable us to use thewasmtime-craneliftgenerated
trampolines in thewasmtime-winchcrate.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 07 2024 at 02:01):elliottt updated PR #8056.
Wasmtime GitHub notifications bot (Mar 07 2024 at 02:02):elliottt edited PR #8056:
Add a
Winchcalling convention to cranelift that has no callee saves, and clobbers everything. This will enable us to use thewasmtime-craneliftgenerated trampolines in thewasmtime-winchcrate.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:08):elliottt has marked PR #8056 as ready for review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:08):elliottt requested cfallin for a review on PR #8056.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:08):elliottt requested wasmtime-compiler-reviewers for a review on PR #8056.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:13):elliottt edited PR #8056:
Add a
Winchcalling convention to cranelift that has no callee saves, and clobbers everything. This will enable us to use thewasmtime-craneliftgenerated trampolines in thewasmtime-winchcrate.I've enabled fuzzing for this calling convention, as well as added clif tests for the
x64andaarch64backends. I've explicitly disabled support inriscv64ands390x, as it's not currently possible to target either of those architectures with winch.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:13):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:13):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:13):alexcrichton created PR review comment:
Could this be shared with
tail_clobbersabove as something likepreg_set_all()?
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:13):alexcrichton created PR review comment:
Like x64, could the shared bits with tail be factored to a helper constant/function?
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:14):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:14):elliottt created PR review comment:
My worry was that we've been discussing adding callee saves back to the tail calling convention, and I didn't want that change to accidentally undo this one.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:16):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:16):alexcrichton created PR review comment:
Oh sure, so not literally sharing the name "tail" but something like a helper function that both tail/winch call, and one day tail will stop calling it
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:20):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:20):elliottt created PR review comment:
That works!
Wasmtime GitHub notifications bot (Mar 07 2024 at 18:30):elliottt updated PR #8056.
Wasmtime GitHub notifications bot (Mar 08 2024 at 17:28):elliottt updated PR #8056.
Wasmtime GitHub notifications bot (Mar 08 2024 at 18:51):elliottt merged PR #8056.
Last updated: Dec 23 2024 at 12:05 UTC