Stream: git-wasmtime

Topic: wasmtime / PR #8051 winch: Defer the usage of `format!`


view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 20:14):

saulecabrera opened PR #8051 from saulecabrera:winch-laziy-construct-formatted-string to bytecodealliance:main:

This commit defers the usage of format! until it's actually needed when retrieving addresses for locals. This helps improve performance in modules that incur in a considerable number of local lookups.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 20:14):

saulecabrera requested elliottt for a review on PR #8051.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 20:14):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8051.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 21:45):

github-actions[bot] commented on PR #8051:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 22:01):

elliottt submitted PR review:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2024 at 22:28):

elliottt merged PR #8051.


Last updated: Dec 23 2024 at 12:05 UTC